Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(run_strategy): nodes for random strategy for otp app #608

Closed
wants to merge 1 commit into from
Closed

feat(run_strategy): nodes for random strategy for otp app #608

wants to merge 1 commit into from

Conversation

marinakr
Copy link

@marinakr marinakr commented Mar 5, 2024 •
edited by maennchen

Resolves #605

@marinakr marinakr mentioned this pull request Mar 5, 2024
Open
@marinakr marinakr force-pushed the random_per_app_run_strategy branch from 8822cc4 to 09de035 Compare March 5, 2024 19:53
@maennchen
Copy link
Member

maennchen commented Mar 5, 2024 •
edited

There's a few to adapt for the PR:

  • Checking if an application runs on the node is not enough. We'll have to see if the task supervisor is up:

    quantum-core/lib/quantum/supervisor.ex

    Line 94 in 748d944

    {Task.Supervisor, task_supervisor_opts},
  • Theoretically a user can run multiple schedulers. Therefore we can't setup the config via the quantum config namespace.
  • All strategies need to implement this, not only the random one.

@maennchen
Copy link
Member

To do this properly, we'll probably have to pass another argument to the NodeList.nodes function that specifies the task supervisor:

quantum-core/lib/quantum/node_selector_broadcaster.ex

Line 73 in 748d944

defp select_nodes(%Job{run_strategy: run_strategy} = job, task_supervisor) do

@marinakr
Copy link
Author

marinakr commented Mar 7, 2024

Close this PR for now - implemented custom strategy

@marinakr marinakr closed this Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

multiple apps in libcluster, quantum does not identifies which node to select
2 participants
@marinakr @maennchen