Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

converting dataframe columns to structure.schema requires cloning #1943

Open
dustmop opened this issue Oct 19, 2021 · 0 comments
Open

converting dataframe columns to structure.schema requires cloning #1943

dustmop opened this issue Oct 19, 2021 · 0 comments
Labels
bug code that is not behaving as expected

Comments

@dustmop
Copy link
Contributor

dustmop commented Oct 19, 2021

In #1942, in function assignStructureFromDataframeColumns in transform/startf/ds/dataset.go, I added a bit of code to clone the schema by serializing and unserializing it. This is required to get the unit tests to pass; if not present, the columns are treated as strings instead of integers, which changes how they are displayed when converted to json. Not sure why this is happening, it would be good to investigate and gain a better understanding of what's going on here, in order to remove this hack.

@dustmop dustmop added the bug code that is not behaving as expected label Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug code that is not behaving as expected
Projects
None yet
Development

No branches or pull requests

1 participant