Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] partial steps in batches envs #1868

Open
vmoens opened this issue Feb 3, 2024 · 1 comment
Open

[Feature Request] partial steps in batches envs #1868

vmoens opened this issue Feb 3, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@vmoens
Copy link
Contributor

vmoens commented Feb 3, 2024

Motivation

In many scenarios we need to perform a step only on a subset of batched envs. This includes collecting a complete trajectory for many envs when they end asynchronously, or partial frame skip and such.

Solution

Serial and parallel envs could read an index key that would indicate which env is to be reset/stepped over.
We need to decide if this key will be a bool or long tensor, which name it'll have, whether it'll be private or not.
For sure users will need to be able to mask the data so we'll need to provide a mask indicating what data is valid.

Alternatives

Eventually we could also index batched envs directly but for now this is a long stretch.

Cc @albertbou92

@vmoens vmoens added the enhancement New feature or request label Feb 3, 2024
@vmoens vmoens self-assigned this Feb 3, 2024
@albertbou92
Copy link
Contributor

albertbou92 commented Feb 8, 2024

Where would the index key be set? in a Transform? or the environment itself would do it?

I think the key could be a bool. named padded step or skipped step maybe?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants