-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Capitalisation typo in expr visitor? #146
Comments
Great catch! I probably should have used |
Reading a bit on this code it does look like the correct fix here is to change the capitalization. As it stands now we're not saving the scope for any assignment that returns from a blackbox call. I reckon this will be a bit tedious to fix since the change makes a bunch of the cfg tests fail because now they have more nodes in the CFG. |
pyt/pyt/cfg/expr_visitor.py
Lines 207 to 209 in e692581
I'm not that sure what the correct behaviour here is.
Capitalisation looks wrong so I think
type(Node) == BBorBInode
will always beFalse
. Removing the check on L209 doesn't affect the tests.However, changing it to
type(node)
causes 15 unit test failures.The text was updated successfully, but these errors were encountered: