-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Poetry creates non-url url entry in direct_url.json #8999
Labels
area/core
Related to the poetry-core library
area/installer
Related to the dependency installer
kind/bug
Something isn't working as expected
status/waiting-on-core
Requires changes to poetry-core first
Comments
konstin
added
kind/bug
Something isn't working as expected
status/triage
This issue needs to be triaged
labels
Feb 21, 2024
Probably relevant: #3113 |
abn
added a commit
to abn/poetry-core
that referenced
this issue
Feb 24, 2024
This change ensures when referencing source url for package specifications of source type "git" or for VCS dependencies, a normalized version returned at all times. Relates-to: python-poetry/poetry#8999
abn
added a commit
to abn/poetry-core
that referenced
this issue
Feb 24, 2024
This change ensures when referencing source url for package specifications of source type "git" or for VCS dependencies, a normalized version returned at all times. Relates-to: python-poetry/poetry#8999
radoering
pushed a commit
to python-poetry/poetry-core
that referenced
this issue
Feb 24, 2024
This change ensures when referencing source url for package specifications of source type "git" or for VCS dependencies, a normalized version returned at all times. Relates-to: python-poetry/poetry#8999
radoering
added
area/installer
Related to the dependency installer
and removed
status/triage
This issue needs to be triaged
labels
Feb 24, 2024
abn
added
area/core
Related to the poetry-core library
status/waiting-on-core
Requires changes to poetry-core first
labels
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/core
Related to the poetry-core library
area/installer
Related to the dependency installer
kind/bug
Something isn't working as expected
status/waiting-on-core
Requires changes to poetry-core first
Summary
With
flask = { git = "[email protected]:pallets/flask.git", rev = "b90a4f1f4a370e92054b9cc9db0efcb864f87ebe" }
poetry write"url": "[email protected]:pallets/flask.git"
in direct_url.json-vvv
option) and have included the output below.Issue
When using a git dependency, the
url
field of thedirect_url.json
that poetry writes is not a url. This causes problems in uv (astral-sh/uv#1744). The spec isn't clear about what the url field contains. I propose to change this both in poetry and in the spec: pypa/packaging.python.org#1506.The text was updated successfully, but these errors were encountered: