-
Notifications
You must be signed in to change notification settings - Fork 643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ProjectMergeRequestApprovalManager.set_approvers cannot handle too many approval rules #2825
Comments
JohnVillalovos
added a commit
that referenced
this issue
May 15, 2024
Use `iterator=True` when going through the list of current approval rules. This allows it to handle more than the default of 20 approval rules. Closes: #2825
nejch
pushed a commit
that referenced
this issue
May 17, 2024
Use `iterator=True` when going through the list of current approval rules. This allows it to handle more than the default of 20 approval rules. Closes: #2825
nejch
pushed a commit
that referenced
this issue
May 17, 2024
Use `iterator=True` when going through the list of current approval rules. This allows it to handle more than the default of 20 approval rules. Closes: #2825
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description of the problem, including code/CLI snippet
In v4/objects/merge_request_approvals.py ~ line 121
An existing approval rule will not be found if it exceeds the default pagination count for list(). It will instead attempt to create it (which will fail because it already exists)
Expected Behavior
approval rule should be found in the list of existing approval rules and be modified.
Actual Behavior
approval rule is not found and creation of new rule fails.
Specifications
I believe this fix is to change
approval_rules.list()
to
approval_rules.list(all=True)
The text was updated successfully, but these errors were encountered: