Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle large number of approval rules #2866

Merged
merged 1 commit into from
May 17, 2024
Merged

fix: handle large number of approval rules #2866

merged 1 commit into from
May 17, 2024

Conversation

JohnVillalovos
Copy link
Member

Use iterator=True when going through the list of current approval rules. This allows it to handle more than the default of 20 approval rules.

Closes: #2825

Copy link
Member

@nejch nejch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah nice, thanks!

@nejch nejch enabled auto-merge (rebase) May 17, 2024 10:05
Use `iterator=True` when going through the list of current approval
rules. This allows it to handle more than the default of 20 approval
rules.

Closes: #2825
@nejch nejch merged commit ef8f0e1 into main May 17, 2024
16 checks passed
@nejch nejch deleted the jlvillal/issue_2825 branch May 17, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ProjectMergeRequestApprovalManager.set_approvers cannot handle too many approval rules
2 participants