Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Installer installs an incorrect .addin file #2250

Open
5 tasks done
IanCundall opened this issue May 14, 2024 · 3 comments
Open
5 tasks done

[Bug]: Installer installs an incorrect .addin file #2250

IanCundall opened this issue May 14, 2024 · 3 comments
Labels
Bug Bug that stops user from using the tool or a major portion of pyRevit functionality [class]

Comments

@IanCundall
Copy link

✈ Pre-Flight checks

  • I don't have SentinelOne antivirus installed (see above for the solution)
  • I have searched in the issues (open and closed) but couldn't find a similar issue
  • I have searched in the pyRevit Forum for similar issues
  • I already followed the installation troubleshooting guide thoroughly
  • I am using the latest pyRevit Version

🐞 Describe the bug

On my machine which has Revit 2020, 2021, 2022, 2023 & 2024 installed, the pyRevit.addin file is pointing at "C:\Program Files\pyRevit-Master\bin\engines\IPY277\pyRevitLoader.dll"

However, the installer (https://github.com/pyrevitlabs/pyRevit/releases/download/v4.8.16.24121%2B2117/pyRevit_4.8.16.24121_admin_signed.exe) installs to:
"C:\Program Files\pyRevit-Master\bin\engines\CPY385"
"C:\Program Files\pyRevit-Master\bin\engines\IPY340PR"
"C:\Program Files\pyRevit-Master\bin\engines\IPY2711PR"
"C:\Program Files\pyRevit-Master\bin\engines\CPY378"

The same occured on a machine with only Revit 2023 installed.

⌨ Error/Debug Message

Revit versions all pop up the standard "Revit cannot load..." message, pointing to the "missing" assembly.

♻️ To Reproduce

  • Install Revit
  • Install pyRevit 4.8.16
  • Start Revit

⏲️ Expected behavior

Revit should prompt the user to trust the add-in

🖥️ Hardware and Software Setup (please complete the following information)

==> Registered Clones (full git repos)
==> Registered Clones (deployed from archive/image)
==> Attachments
Unknown | Product: "24.2" | Manifest: "C:\ProgramData\Autodesk\Revit\Addins\2024\pyRevit.addin"
Unknown | Product: "23.1.3" | Manifest: "C:\ProgramData\Autodesk\Revit\Addins\2023\pyRevit.addin"
Unknown | Product: "2022.1.5" | Manifest: "C:\ProgramData\Autodesk\Revit\Addins\2022\pyRevit.addin"
Unknown | Product: "2021.1.9" | Manifest: "C:\ProgramData\Autodesk\Revit\Addins\2021\pyRevit.addin"
Unknown | Product: "2020.2.9" | Manifest: "C:\ProgramData\Autodesk\Revit\Addins\2020\pyRevit.addin"
==> Installed Extensions
==> Default Extension Search Path
C:\Users\[user ID redacted]\AppData\Roaming\pyRevit\Extensions
==> Extension Search Paths
==> Extension Sources - Default
https://github.com/pyrevitlabs/pyRevit/raw/master/extensions/extensions.json
==> Extension Sources - Additional
==> Installed Revits
24.2 | Version: 24.2.0.63 | Build: 20231029_1515(x64) | Language: 1033 | Path: "C:\Program Files\Autodesk\Revit 2024\"
23.1.3 | Version: 23.1.30.97 | Build: 20230828_1515(x64) | Language: 1033 | Path: "C:\Program Files\Autodesk\Revit 2023\"
2022.1.5 | Version: 22.1.50.17 | Build: 20230915_1530(x64) | Language: 1033 | Path: "C:\Program Files\Autodesk\Revit 2022\"
2021.1.9 | Version: 21.1.90.15 | Build: 20230907_1515(x64) | Language: 1033 | Path: "C:\Program Files\Autodesk\Revit 2021\"
2020.2.9 | Version: 20.2.90.12 | Build: 20220517_1515(x64) | Language: 1033 | Path: "C:\Program Files\Autodesk\Revit 2020\"
==> Running Revit Instances
==> User Environment
Microsoft Windows 10 [Version 10.0.22621]
Executing User: [domain name redacted]\[user ID redacted]
Active User:
Admin Access: No
%APPDATA%: "C:\Users\[user ID redacted]\AppData\Roaming"
Latest Installed .Net Framework: 4.8
No .Net Target Packs are installed.
No .Ne-Core Target Packs are installed.
pyRevit CLI v4.8.16.24121+2117.23a0b8cbc4babdeb29a0611e159d017bbe9cbad5

Additional context

No response

@IanCundall IanCundall added the Bug Bug that stops user from using the tool or a major portion of pyRevit functionality [class] label May 14, 2024
@IanCundall
Copy link
Author

IanCundall commented May 14, 2024

No .Ne-Core Target Packs are installed.

I suspect this message should say:
No .Net Core Target Packs are installed.

jmcouffin added a commit that referenced this issue May 17, 2024
@jmcouffin
Copy link
Contributor

No .Ne-Core

Typo is fixed in develop-4 branch.
Latest WIP installer will issue the fix.
Thanks,

The rest of the issue is more complicated and will be looked whenever possible

@sanzoghenzo
Copy link
Contributor

HI @IanCundall,
have you tried to pyrevit attach 2711? the IronPython 2.7.7 engine was removed in the latest version of pyrevit, and it probably the installer didn't update the .addins file to point to the new location.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Bug that stops user from using the tool or a major portion of pyRevit functionality [class]
Projects
None yet
Development

No branches or pull requests

3 participants