Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When developing on Windows, a git clone operation may automatically convert file line endings to CRLF, leading to a Sad #15980

Closed
miketheman opened this issue May 20, 2024 · 0 comments · Fixed by #15982
Labels
bug 🐛 developer experience Anything that improves the experience for Warehouse devs

Comments

@miketheman
Copy link
Member

miketheman commented May 20, 2024

Describe the bug
Our docs tell users to git clone the repo, and if performed in the outer context (Windows CLI), this can lead to git changing file endings and making the shells scripts non-executable by our docker containers.

Expected behavior
make commands on Windows complete successfully.

Proposed solution

Create a .gitattributes file in the root of the repo, setting all files to be lf (or \n - whichever is the correct config), so anyone cloning the code on Windows will not run into this as well.

Refs:

Credit to @AshtonWooster who uncovered this problem!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 developer experience Anything that improves the experience for Warehouse devs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant