Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add verifiable cryptographic signature to email event in "security history" log #15974

Open
monperrus opened this issue May 18, 2024 · 1 comment
Labels
feature request requires triaging maintainers need to do initial inspection of issue

Comments

@monperrus
Copy link

What's the problem this feature will solve?
Verifying the event trail in security history

Describe the solution you'd like
Add a field signature to the event

From: [email protected]
To: [email protected]
Subject: [PyPI] Two-factor method added
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple;
	s=qnyyfqodjxtnsobvnrsglem3olqxgb5o; d=pypi.org; t=1716013242;
	h=Subject:From:To:MIME-Version:Content-Type:Message-ID:Date;
	bh=sBC+yG9GSD1CnHoXXbcy9jcoanUnWeFQgXevQ7vrQ/o=;
	b=Idqy0AQzQeKAKPCkC/MvBx68S+5bGEsHdJ+MQHRMLtuVYQ4oqG7CH3dvB4VPeB+/
	KUjxrOU/ew3veyGZLNk8igmcxcXgJLplKWxVwi4kpni8/u9FurWd7KWJsBo6UH9DO1H
	lp8nQdB1rqPq3dOFXhcsvNM0lt3X+H86bv6bXNjI=

Additional context
Any signature would work. The advantage of DKIM-Signature is that 1) it is already there 2) there is email client support to verify DKIM-Signature

@monperrus monperrus added feature request requires triaging maintainers need to do initial inspection of issue labels May 18, 2024
@woodruffw
Copy link
Member

Making sure I understand: are you asking for a DKIM signature for the per-project "security history" page on pypi.org itself, or are you asking about the DKIM signature on the security emails themselves?

(If it's the latter, I think PyPI already issued DKIM-signed message bodies, since all of the emails in my inbox have the DKIM-Signature header. If it's the former, I think the value of signatures in the "security history" log would be minimal, since PyPI itself has transport security. But I could be misunderstanding.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request requires triaging maintainers need to do initial inspection of issue
Projects
None yet
Development

No branches or pull requests

2 participants