-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Someday: Use importlib.metadata
from the standard library
#773
Comments
3.10 is now officially released, so this could be revisited. I'm open for writing a PR if you want. |
eli-schwartz
added a commit
to eli-schwartz/twine
that referenced
this issue
Oct 26, 2023
The use of importlib_metadata relies on features that were introduced in python 3.10. Aside for that, it should be fine to use the stdlib directly. Fixes pypa#773
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Follow-up to #772 (review) and #732 (comment).
It'd be nice to remove the dependency on
importlib_metadata
in Python 3.10+, but Twine will still need it for as long as it supports older versions of Python. So, I think it's worth weighing the complexity of conditional imports vs. an additional dependency.I think this should at least wait until 3.10 is officially released and is added to Twine's testing matrix. If we do decide to use
importlib.metadata
, then I think the version check should be done in one place, as suggested in #772 (comment).The text was updated successfully, but these errors were encountered: