Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Pass version to custom metadata hook #1348

Open
potiuk opened this issue Mar 25, 2024 · 0 comments · May be fixed by #1511
Open

Feature: Pass version to custom metadata hook #1348

potiuk opened this issue Mar 25, 2024 · 0 comments · May be fixed by #1511

Comments

@potiuk
Copy link
Contributor

potiuk commented Mar 25, 2024

Currently the CustomMetadataHook does not pass "version" information ("standard" / "editable" ) to update method which specifically impacts projects that set "optional-dependencies". This does not allow more dynamic calculation of the metadata, that depends on whether "editable" or "standard" build is run. Currently the "editable" and "standard" distinction is only available in the CustomBuildHook and projects need to hack around overriding the metadata there.

Example case for this is apache-airflow in here: https://github.com/apache/airflow/blob/420709962ec864fa62b6e1b6c2f723a2c14cb751/hatch_build.py#L751

Discussed in astral-sh/uv#2130 (comment)

This one is Hatchling related.

potiuk added a commit to potiuk/hatch that referenced this issue May 20, 2024
This is a very draft proposal on how to fix pypa#1348 and pypa#1349 - more
to see if this is a good direction. It should likely be split to
two PRs (and of course tests and docs are needed):

* extending custom metadata plugin to allow different versions for
  standard and editable builds (also including extending the hatchling
  CLIs.

* extending hatchling interface used by hatch to include standard/
  editable version when querying hatchling for available dependencies

Not all changes have been yet applied, this is more to check if
this is the right direction.
potiuk added a commit to potiuk/hatch that referenced this issue May 20, 2024
This is a very draft proposal on how to fix pypa#1348 and pypa#1349 - more
to see if this is a good direction. It should likely be split to
two PRs (and of course tests and docs are needed):

* extending custom metadata plugin to allow different versions for
  standard and editable builds (also including extending the hatchling
  CLIs.

* adding version to CLI where hatch queries hatchling to include standard/
  editable version when querying for available dependencies.

Not all changes have been yet applied, this is more to check if
this is the right direction.
potiuk added a commit to potiuk/hatch that referenced this issue May 27, 2024
This is a very draft proposal on how to fix pypa#1348 and pypa#1349 - more
to see if this is a good direction. It should likely be split to
two PRs (and of course tests and docs are needed):

* extending custom metadata plugin to allow passing version through
  hook's version property to distinguish standard and editable builds
  (also including extending the hatchling CLIs.

* adding version to CLI where hatch queries hatchling to include standard/
  editable version when querying for available dependencies.

Not all changes have been yet applied, this is more to check if
this is the right direction.
potiuk added a commit to potiuk/hatch that referenced this issue May 27, 2024
This is a very draft proposal on how to fix pypa#1348 and pypa#1349 - more
to see if this is a good direction. It should likely be split to
two PRs (and of course tests and docs are needed):

* extending custom metadata plugin to allow passing version through
  hook's version property to distinguish standard and editable builds
  (also including extending the hatchling CLIs.

* adding version to CLI where hatch queries hatchling to include standard/
  editable version when querying for available dependencies.

Not all changes have been yet applied, this is more to check if
this is the right direction.
potiuk added a commit to potiuk/hatch that referenced this issue May 27, 2024
This is a very draft proposal on how to fix pypa#1348 and pypa#1349 - more
to see if this is a good direction. It should likely be split to
two PRs (and of course tests and docs are needed):

* extending custom metadata plugin to allow passing version through
  hook's version property to distinguish standard and editable builds
  (also including extending the hatchling CLIs.

* adding version to CLI where hatch queries hatchling to include standard/
  editable version when querying for available dependencies.

Not all changes have been yet applied, this is more to check if
this is the right direction.
potiuk added a commit to potiuk/hatch that referenced this issue May 29, 2024
This is a very draft proposal on how to fix pypa#1348 and pypa#1349 - more
to see if this is a good direction. It should likely be split to
two PRs (and of course tests and docs are needed):

* extending custom metadata plugin to allow passing version through
  hook's version property to distinguish standard and editable builds
  (also including extending the hatchling CLIs.

* adding version to CLI where hatch queries hatchling to include standard/
  editable version when querying for available dependencies.

Not all changes have been yet applied, this is more to check if
this is the right direction.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant