Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide progress callback support for downloading index and packs #94

Open
flit opened this issue Apr 18, 2019 · 1 comment
Open

Provide progress callback support for downloading index and packs #94

flit opened this issue Apr 18, 2019 · 1 comment

Comments

@flit
Copy link
Member

flit commented Apr 18, 2019

The Python API needs to support a caller-provided progress callback for the cache_descriptors() and download_pack_list() methods.

Ideally the progress callback would be provided with

  • The name of the file currently being downloaded.
  • URL of current file.
  • Percent complete for current file.
  • Maybe also a total percent complete.
@theotherjimmy
Copy link
Collaborator

theotherjimmy commented May 7, 2019

@flit I would like to implement this, and I should have all of the information needed through the Rust side of the API. It is in part a matter of wiring things up. Be aware that if you ask for more than one file to be downloaded, that they may be downloaded in parallel. With your proposed API, you would get calls to that progress callback with different file, url pairs interleaved. This is probably fine, I just want to make sure we're all on the same page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants