Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opensubtitles.org API returns stub subtitle for all searches as it is no longer functional #11643

Open
Frank071 opened this issue Mar 1, 2024 · 6 comments

Comments

@Frank071
Copy link

Frank071 commented Mar 1, 2024

Describe the bug
The opensubtitles.org API no longer functions for non VIP members, but 'no longer functions' is implemented as 'responds with a one line subtitle to every request'. This means that applications like Medusa thinks it has the subtitle and downloads it.

To Reproduce
Check any subtitle downloaded via the opensubtitles API after Jan 1st, 2024

Expected behavior
To avoid misinterpretation it is better to remove the opensubtitles provider. Users with VIP access can activate the opensubtitlesvip provider and it will continue to work (for now). Those without VIP access will no longer get these stub subtitles.

Additional context
Supporting the new API would be a nice update for Medusa. Information can be found here.

@BenjV
Copy link
Contributor

BenjV commented Mar 2, 2024

I would be willing to create the code for the new Opensubtitle API.
But a Medusa developer has to create a API key and a useragent name for medusa on Opensubtitle site because that is needed for the new Opensubtitles API.

@Frank071
Copy link
Author

Frank071 commented Mar 2, 2024

I don't think that will happen as the free use of the API is pretty limited. If you register as user of opensubtitles, you van create an API key yourself. Wouldn't it be a better solution to make this key a configurable option? In addition to to the current user/pass combination (it looks as if the use of the API key when logged in is less limited).

(But it might be that I completely misunderstood the new API scheme)

@BenjV
Copy link
Contributor

BenjV commented Mar 2, 2024

No that's not the case
You need an API key and a useragent string for the applicatie in this case Medusa and then a user could create an account with a username and password which then can be entered in Medusa to be used.
So a Medusa developer should registar Medusa as an application and will get an Application API and a useragent string.
Then in the user interface of Medusa a user could enter his username and password for his Opensubtiles account and all will be fine.

I am using this in my own private application and are willing to share the code with Medusa.

@007revad
Copy link

Is there any update on this?

@BenjV
Copy link
Contributor

BenjV commented Mar 18, 2024

No response from any of the developers!

@gazmeist
Copy link

Yup turned off opensubtitles for exactly this reason - too many useless 1kb files. Only allows you 10 files a day

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants