Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alt text needs fixing #226

Open
OriolAbril opened this issue Apr 3, 2023 · 1 comment
Open

Alt text needs fixing #226

OriolAbril opened this issue Apr 3, 2023 · 1 comment

Comments

@OriolAbril
Copy link
Member

I have just noticed that all the images in https://github.com/pymc-devs/pymc-data-umbrella/blob/main/2023-03_sprint/sprint_parties/contributors.md?plain=1 have "Image for contributor template" as alt text.

Following the advise in https://webaim.org/techniques/alttext/, and given all images are immediately followed by the name of the person they picture, I think it would be appropriate to use alt="" (similar to example 2). Another option could be using the name as alt text too (similar to example 1). Either way, I think the current content is negative and worse than having no alt text.

cc @reshamas @symeneses Once we agree on one of the two options above I think this can be labeled "good first issue"

@symeneses
Copy link
Contributor

According to WebAIM, it's better to leave it empty to avoid being redundant as the name is near the image. So, I think that's the best option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants