Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Path chooser does not load due to X-Frame-Options: DENY #4422

Open
mschfh opened this issue Jan 6, 2024 · 2 comments
Open

Path chooser does not load due to X-Frame-Options: DENY #4422

mschfh opened this issue Jan 6, 2024 · 2 comments
Assignees
Labels
plugin bug Plugin isn't working pyLoad Stable

Comments

@mschfh
Copy link

mschfh commented Jan 6, 2024

Description

The path chooser does not work as "X-Frame-Options: DENY" prevents the iframe from being loaded.

steps to reproduce:

  1. Settings -> General
  2. Click on "Browse" next to "Download folder"
image 3. The path chooser doesn't load, there is an error in the browser console image
Refused to display 'http://localhost:8000/' in a frame because it set 'X-Frame-Options' to 'deny'.

Additional references

X-Frame-Options is being deprecated in favor of the frame-ancestors CSP directive, perhaps replace it with:

Content-Security-Policy: frame-ancestors 'self';
@mschfh mschfh added plugin bug Plugin isn't working pyLoad Stable labels Jan 6, 2024
@GammaC0de
Copy link
Member

perhaps replace it with:
Content-Security-Policy: frame-ancestors 'self';

I can see you're using MacOS which I do not have.
Have you checked that your suggestion solve the issue for you?

@mschfh
Copy link
Author

mschfh commented Jan 19, 2024

This should affect all platforms / standard-compliant browsers.
I only tested X-Frame-Options: SAMEORIGIN, not the CSP change (which would be more of an enhancement than a bug fix).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin bug Plugin isn't working pyLoad Stable
Development

No branches or pull requests

2 participants