From 7857f9c9c4bc30cafc6bb3d5aaf403d31b87cd8c Mon Sep 17 00:00:00 2001
From: pylipp <philipp.metzner@tum.de>
Date: Mon, 30 Dec 2019 21:21:33 +0100
Subject: [PATCH] Deprecate flask-webservice related functionality

- affects modules: httprequests, fflask, resources
- probably in version v0.24.0.0
- related to #53
---
 Changelog.md           | 1 +
 README.md              | 2 ++
 financeager/clients.py | 7 +++++++
 3 files changed, 10 insertions(+)

diff --git a/Changelog.md b/Changelog.md
index defe4f7..1270ab1 100644
--- a/Changelog.md
+++ b/Changelog.md
@@ -20,6 +20,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
 - The versioning scheme now adheres to '0.major.minor.patch' to correctly indicate impacts of new releases. (#54)
 - The 'communication' module is renamed to 'clients'.
 ### Deprecated
+- Flask-webservice related functionality will be moved to a dedicated plugin. (#53)
 ### Removed
 - communication.module() and httprequests/localserver.proxy() functions.
 ### Fixed
diff --git a/README.md b/README.md
index 4983ecb..63a702e 100644
--- a/README.md
+++ b/README.md
@@ -42,6 +42,8 @@ The user request invoked from the CLI is passed to the backend which opens the a
 
 ### Client-server mode
 
+>   Flask-webservice related functionality will be moved to a dedicated plugin, see #53.
+
 To run `financeager` as client-server application, start the flask webservice by
 
     export FLASK_APP=financeager/fflask.py
diff --git a/financeager/clients.py b/financeager/clients.py
index acaf6e0..87b64d5 100644
--- a/financeager/clients.py
+++ b/financeager/clients.py
@@ -6,6 +6,8 @@
 from . import httprequests, localserver, offline, plugin
 from .exceptions import InvalidRequest, CommunicationError, OfflineRecoveryError
 
+logger = financeager.init_logger(__name__)
+
 
 def create(*, configuration, sinks, plugins):
     """Factory to create the Client subclass suitable to the given
@@ -88,6 +90,11 @@ def __init__(self, *, configuration, sinks):
 
         financeager.init_logger("urllib3")
 
+        logger.warning(
+            "Flask-webservice related functionality will be moved to a "
+            "dedicated plugin.\n"
+            "Check the Changelog when updating your financeager version.")
+
     def safely_run(self, command, **params):
         """Execute base functionality.
         If successful, attempt to recover offline backup. Otherwise store