-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keep the messages states per file #938
Labels
Per directory config
New per directory config feature
Comments
This sounds good to me! 👍 |
I'm going to close this as we're no longer focusing on making |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This issue is circumstantial with #618, which proposes making PyLinter classes as lightweight as possible, targeting one file.
Currently, we have some problems related to the fact that the messages stores and states are for the current analyzed file and not for all the files that Pylint should analyze. This means that currently, we can't have the information about a pragma disable in another file, which would be useful for solving #214 for instance.
Moving to a global message store for all the files seems in line with #618. The changes that this issue involves, without taking in consideration #618 for now, could be to move the token checker outside of PyLinter class and creating one per file, parsing the files to get the AST and for getting the pragmas, holding the pragmas and other relevant information somewhere where the checkers could access them and removing the global bits from PyLinter, which should be per file, instead of relying on the current analyzed file.
Since we are rewriting how the PyLinter class acts and behave, I think this is the best time to refactor this.
@AWhetter let me know what do you think. I will try to come up with better details later on.
The text was updated successfully, but these errors were encountered: