Don't resolve symlinks. #2128
Closed
Don't resolve symlinks. #2128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2128 +/- ##
==========================================
- Coverage 92.73% 92.72% -0.01%
==========================================
Files 94 94
Lines 11007 11004 -3
==========================================
- Hits 10207 10204 -3
Misses 800 800
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Could you add a test for this? This could very easily break in the future without a regression test. See also It seems there was a good reason to add symlink support, but since those commits also lack all tests we can't make a good judgement call right now. |
|
Closing per comment. Feel free to pursue this further and open a new PR. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
This patch removes code that resolves symlinks when resolving a module path.
This causes problems, as described in the linked-to bug, and IMHO since the Python interpreter doesn't resolve symlinks there's no good reason why a code analyzer should do so.
Closes: #2127.