-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please make v2 compatible with v1 (langchain use v1, while fastapi use v2) #7919
Comments
Seems like the onus is on langchain. |
Hi @mokeyish, Thanks for submitting this issue. I agree with @Luca-Blight, this is simply a case of conflicting dependencies. You could use an earlier version of Any Read more here: tiangolo/fastapi#9709 |
I found that it also not compatiable with deepspeed. Each library has its own dependencies, and many of them now conflict with each other. |
You can use different versions of each library to make sure the versions are compatible. The burden of resolving version conflicts isn't on |
Currently, fastapi/lmdeploy use v2, langchain/deepspeed use v1. Don’t learn from Google, learn from Facebook. As I known, Google has two incompatible upgraded products, angular(v1->v2) and tensorflow(v1->v2). Facebook's react and pytorch have always been very compatible, even from pytorch v1 to v2.
|
I'm not the only one having this problem. |
Hi @mokeyish, the rewrite in Pydantic from V1 to V2 was a fundamental restructure of the codebase, virtually everything (except the unit test, the philosophy and the majority of the public API) changed. There won't be another breaking change to Pydantic like this. I'd love Pydantic V1 to be compatible with Pydantic V2, the problem is that doing a thorough job of it would take me and someone else 6 months of solid work. That's 6 months we don't spend improving V2. On balance I don't think that's a good use of my time. As @Luca-Blight said, the onus has to be on dependent libraries to upgrade.
Pydantic is currently downloaded 123m times a month. That's 47 times a second. I'm not sure what point you were trying to make by including links to 3 issues, but the way I read it, it shows what a small proportion of Pydantic's use is affective by v1 vs. v2 compatibility. |
Initial Checks
Description
Please make v2 compatible with v1 (langchain use v1, while fastapi use v2). they can't work together.
Example Code
No response
Python, Pydantic & OS Version
The text was updated successfully, but these errors were encountered: