Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore man page rendering dropped by pull request #194 #193

Open
ssbarnea opened this issue Jan 14, 2023 · 4 comments
Open

Restore man page rendering dropped by pull request #194 #193

ssbarnea opened this issue Jan 14, 2023 · 4 comments
Assignees
Labels
bug This issue/PR relates to a bug.

Comments

@ssbarnea
Copy link
Member

Apparently https://github.com/asciidoc-py/asciidoc-py is declared legacy and have lots of problems, including inability to parse current version of the specification or to work under MacOS.

In order to be able to setup the CI pipeline on the project we will just remove all its use and look for help to get someone to provide an alternative.

@hartwork
Copy link
Collaborator

hartwork commented Jan 14, 2023

@ssbarnea I won't be able to bump to 1.9.0rc1 in Gentoo without a man page. Man page rendering was working fine in CI before 98ce41f and now we have a release without a man page just because of that refactoring. Let's not break things like that next time and discuss upfront please. Thank you.

Related: #194

@hartwork hartwork changed the title Remove dependency on legacy py-ascidoc Restore man page rendering dropped in #194 / Remove dependency on legacy py-ascidoc Jan 14, 2023
@hartwork
Copy link
Collaborator

PS: @ssbarnea while asciidoc-py is marked legacy, it has its latest release 10.2.0 in 2022-05 and homebrew has that version packaged. Could you share what error you get when rendering the man page on macOS with latest asciidoc-py? PPS: The alternative to asciidoc-py is https://github.com/asciidoctor/asciidoctor but it's written in Ruby.

@ssbarnea
Copy link
Member Author

ssbarnea commented Jan 14, 2023

@hartwork Please make a PR to restore the functionality, GHA is also running on macos so we should see the results.

TBH, I was horrified about the behavior and the lack of info on how to address, that is why I just disabled the page, temporary. Let's fix it before the release!

I am also inclined to switch to markdown like mkdocs for documentation but I need to find a solution to generate the man page from these. More than open to suggestions.

@hartwork
Copy link
Collaborator

@ssbarnea

  • There is pull request Restore man page rendering #202 now.
  • Error 127 means "command not found", e.g. see bash -c 'xxx; echo $?'.
  • I see neither an apology nor asciidoc-py error output from you above.
  • I should not be the one to fix this. A revert or you debugging and fixing this would have been protocol.
  • I'm not amused, not one bit, to be clear. This is not how collaboration works 😠

@hartwork hartwork changed the title Restore man page rendering dropped in #194 / Remove dependency on legacy py-ascidoc Restore man page rendering dropped by pull request #194 Jan 14, 2023
@ssbarnea ssbarnea self-assigned this Jan 16, 2023
@ssbarnea ssbarnea added the bug This issue/PR relates to a bug. label Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants