Fix py4j jar path for Windows #522
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adoebber
changed the title
HyukjinKwon
reviewed
Jun 7, 2023
|
I am excluding some matrix and make the tests unflaky. I will revisit once it's done |
|
Sorry for the delay. Now the tests are fixed per #519. Would you mind rebasing this one please? |
adoebber
force-pushed
the
issue-521-fix-jar-path-for-windows
branch
from
87cfed2
to
ad36cbc
Compare
|
The branch is rebased now. |
HyukjinKwon
reviewed
Mar 11, 2024
| os.path.realpath(__file__)), "../../../../share/py4j/" + jar_file)) | ||
| elif sys.platform == "win32": | ||
| # pip install py4j # On Windows without admin privileges |
There was a problem hiding this comment.
What happen if we install this with admin privileges?
There was a problem hiding this comment.
Then it is installed in C:\Program Files\Python\share\py4j and line 202 will apply.
|
@HyukjinKwon Would you like to close the PR now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that a path is missing when searching for py4j.jar.
Fixes #521