Skip to content
This repository has been archived by the owner on Oct 13, 2021. It is now read-only.

Resources are not cleaned up when repository subpath is empty #102

Open
sebastianrosch opened this issue Mar 12, 2019 · 2 comments
Open
Labels
bug Something isn't working

Comments

@sebastianrosch
Copy link
Contributor

As hinted at in #92, Faros does not delete resources in Kubernetes that were deleted from the repository when there are no other resources in the repository subpath. It just prints no files for subpath '<subpath>'.

In my tests, an empty .yaml file in the subpath was enough for Faros to delete the remaining resources.

@sebastianrosch
Copy link
Contributor Author

As proposed in #100 and #101, a more explicit delete would be one way to avoid this.

@tshak
Copy link
Contributor

tshak commented Mar 12, 2019

From a safety perspective I actually like this behavior. Maybe the fix is to just improve the error message and (not mutually exclusive) implement the attribute based deletion.

@JoelSpeed JoelSpeed added the bug Something isn't working label May 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants