✨ Create flag for new PROS project to choose between 3 or 4 #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Christopher-Tan
changed the title
omegaStag
changed the title
4 tasks
|
Honestly, not sure if this is necessary anymore with #256 , I say this only because the rationale behind these flags is to not force users to use PROS 4. However, with the open beta testing coming up in a month that might be the period that we need in terms of lead time to allow people to transition. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Created pros-4 flag that allows choosing between PROS 4 and 3.
Motivation:
Since there are breaking changes between the two versions, the user should be aware of which PROS version they are installing.
References (optional):
Closes Issue #243
Test Plan:
Once PROS 4 is released, the flag can be used and the version can be checked.