-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Developer login visibility dependent on ENV['SSO_DOMAIN'] existence #1500
Comments
So aside from the visibility issue, I was having issues with the oauth action, too, but turns out my port problem was due to my bringing over the I just needed to tell the Procfile.dev to use port 3000 explicitly and then it aligned with the seeded data: Procfile.dev:
|
This is probably because we're using Omniauth's developer strategy to enable the developer bypass. It should be possible to avoid the check for |
Maybe more of a Gotcha than a Bug. As a Developer, getting the app running with docker and without using the
.env
file, I wasn't finding the "Continue as Developer" option from the session form.The view is checking the presenter for the existence of the
SSO_DOMAIN
value in addition to theRails.env.development?
check here: https://github.com/pupilfirst/pupilfirst/blob/master/app/views/users/sessions/new.html.erb#L15. The developer-specific option seems like it should be outside of the general oauth scope.It also might be more clear if the default value for SSO_DOMAIN was "localhost:5100" which seems to be the out of the box value currently.Setting the SSO_DOMAIN value displays all the options, including the developer one:
Desktop (please complete the following information):
The text was updated successfully, but these errors were encountered: