-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Puma config get evaluated twice with pumactl #3364
Comments
The config file is evaluated in 2 places when called from
In both cases, config files are evaluated by the
This does appear to be a double evaluation of configuration, but what is the right thing to do here? We could pass the parsed configuration through the |
Sounds like the complexity is needed to do the right thing? Or are we lacking one layer of abstraction? |
This does feel like necessary complexity. The least intrusive way I can think to handle this scenario is to add an additional, optional, positional argument to
Did you have any abstraction ideas in mind? |
Describe the bug
There's a difference in behavior in
puma
andpumactl
for non-Puma specific code.I'm not sure if I'd categorize it as a bug, since I can empathize with the thought it's not Puma's responsibility as the APIs are not Puma-specific. However, seeing our
at_exit
hook being called twice was surprising.Puma config:
To Reproduce
Run either puma or pumactl and send a
SIGINT
signal:Expected behavior
The config should get evaluated only once, both using
puma
andpumactl
.Desktop (please complete the following information):
The text was updated successfully, but these errors were encountered: