Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OrgId is mandatory in RuleGroup while it is not in Terraform #110

Open
guifran001 opened this issue Dec 15, 2023 · 3 comments
Open

OrgId is mandatory in RuleGroup while it is not in Terraform #110

guifran001 opened this issue Dec 15, 2023 · 3 comments

Comments

@guifran001
Copy link

In the documentation, most of the resources can take a OrgId as input documented like that:

The Organization ID. If not set, the Org ID defined in the provider block will be used.

But OrgId is mandatory for RuleGroup and enforced here:
https://github.com/lbrlabs/pulumi-grafana/blob/5561b3334f91460d165fb2ac938857086a0f443a/sdk/go/grafana/ruleGroup.go#L180

But on the terraform side, it is optional:
https://github.com/grafana/terraform-provider-grafana/blob/f2a3013f6cd24acfcc27fe95b020190c316bf95a/internal/resources/grafana/oss_org_id.go#L18

Since the SDK code is generated, I do not understand where the code ensuring that it is not nil comes from. Therefore, I cannot provide a pr for a fix.
I understand now: Terraform made the change not long ago:
grafana/terraform-provider-grafana@f3b1845

Is the update of the terraform provider is automated and can be triggered or a pull request must be opened ?

@guifran001
Copy link
Author

From what I'm seeing, it would be fixed by pr #103

@CyberArkCH3
Copy link

Any movement on this request?

@ringods
Copy link
Member

ringods commented Apr 15, 2024

@guifran001 @CyberArkCH3 can you retry with version v0.4.0 (or later) and report back if it solves your problem?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants