Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reenable automerge for new version PRs of community packages #4424

Open
ringods opened this issue Apr 30, 2024 · 1 comment
Open

Reenable automerge for new version PRs of community packages #4424

ringods opened this issue Apr 30, 2024 · 1 comment
Assignees
Labels
kind/enhancement Improvements or new features
Milestone

Comments

@ringods
Copy link
Member

ringods commented Apr 30, 2024

Hello!

  • Vote on this issue by adding a 馃憤 reaction
  • If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details

In #2705, automerge got disabled for new version PRs of community packages due to some artifacts missing from the community package.

Since then, I have been following up on the PRs created by the "new version check" workflow for community packages and hitting the merge button manually for these.

Since the introduction of the pull request template (#3366) to add a new community package, new community packages have a "complete" setup before the first version of the package gets published in our registry. The new version PRs for community packages rarely have a failing build because of the initial completeness check.

Can we enable automerge again for new version PRs having a green build?

Affected area/feature

Registry publishing for community packages.

@ringods ringods added kind/enhancement Improvements or new features needs-triage labels Apr 30, 2024
@sean1588 sean1588 self-assigned this May 6, 2024
@sean1588 sean1588 added this to the 0.104 milestone May 6, 2024
@sean1588
Copy link
Member

sean1588 commented May 7, 2024

I'd be completely fine with enabling auto-merge for these PRs that are just new version releases, as we manually just push these through anyway whenever we see them. I think the only ones that should need a manual check are the initial PRs to add the package, but any version updates following should just auto-merge. I am fairly confident in this since we build all the packages anyway on a PR build now so if something was to break the build, it wouldn't be able to merge through anyway. What do you think @cnunciato?

@interurban interurban modified the milestones: 0.104, 0.105 May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Improvements or new features
Projects
Status: 馃幀 Ready
Development

No branches or pull requests

3 participants