New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
After Pulumi 3.113.0 we started getting Never's for pulumi applied outputs in mypy #16027
Labels
area/sdks
Pulumi language SDKs
customer/lighthouse
Lighthouse customer bugs
kind/bug
Some behavior is incorrect or out of spec
language/python
resolution/fixed
This issue was fixed
Milestone
Comments
rshade
added
kind/bug
Some behavior is incorrect or out of spec
needs-triage
Needs attention from the triage team
customer/lighthouse
Lighthouse customer bugs
labels
Apr 22, 2024
Frassle
added
area/sdks
Pulumi language SDKs
language/python
and removed
needs-triage
Needs attention from the triage team
labels
Apr 22, 2024
|
Frassle
added a commit
that referenced
this issue
May 7, 2024
Fixes #16027. Seems mypy was having issues with Outputs being passed into these methods and tracking that they should have just been returning the same Output in the result. Adding these extra overloads seems to have appeased the type checker when using these methods.
6 tasks
Frassle
added a commit
that referenced
this issue
May 7, 2024
Fixes #16027. Seems mypy was having issues with Outputs being passed into these methods and tracking that they should have just been returning the same Output in the result. Adding these extra overloads seems to have appeased the type checker when using these methods.
github-merge-queue bot
pushed a commit
that referenced
this issue
May 7, 2024
) <!--- Thanks so much for your contribution! If this is your first time contributing, please ensure that you have read the [CONTRIBUTING](https://github.com/pulumi/pulumi/blob/master/CONTRIBUTING.md) documentation. --> # Description <!--- Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. --> Fixes #16027. Seems mypy was having issues with Outputs being passed into these methods and tracking that they should have just been returning the same Output in the result. Adding these extra overloads seems to have appeased the type checker when using these methods. ## Checklist - [x] I have run `make tidy` to update any new dependencies - [x] I have run `make lint` to verify my code passes the lint check - [x] I have formatted my code using `gofumpt` <!--- Please provide details if the checkbox below is to be left unchecked. --> - [ ] I have added tests that prove my fix is effective or that my feature works <!--- User-facing changes require a CHANGELOG entry. --> - [x] I have run `make changelog` and committed the `changelog/pending/<file>` documenting my change <!-- If the change(s) in this PR is a modification of an existing call to the Pulumi Cloud, then the service should honor older versions of the CLI where this change would not exist. You must then bump the API version in /pkg/backend/httpstate/client/api.go, as well as add it to the service. --> - [ ] Yes, there are changes in this PR that warrants bumping the Pulumi Cloud API version <!-- @pulumi employees: If yes, you must submit corresponding changes in the service repo. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/sdks
Pulumi language SDKs
customer/lighthouse
Lighthouse customer bugs
kind/bug
Some behavior is incorrect or out of spec
language/python
resolution/fixed
This issue was fixed
What happened?
We upgraded an existing stack to pulumi 3.113.0 and mypy started throwing the following errors:
Example
Output of
pulumi about
pulumi about
CLI
Version 3.113.3
Go Version go1.22.2
Go Compiler gc
Plugins
KIND NAME VERSION
resource aws 6.32.0
language python unknown
resource random 4.16.1
Host
OS ubuntu
Version 20.04
Arch x86_64
This project is written in python: version='3.8.10'
Dependencies:
NAME VERSION
mypy 1.9.0
pip 24.0
pkg_resources 0.0.0
pulumi_aws 6.32.0
pulumi_random 4.16.1
pyright 1.1.359
wheel 0.43.0
Additional context
No response
Contributing
Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).
The text was updated successfully, but these errors were encountered: