New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Diff displayed even when provider returns DIFF_NONE and empty detailed diff #15944
Labels
area/cli
UX of using the CLI (args, output, logs)
kind/bug
Some behavior is incorrect or out of spec
resolution/fixed
This issue was fixed
Comments
VenelinMartinov
added
kind/bug
Some behavior is incorrect or out of spec
needs-triage
Needs attention from the triage team
labels
Apr 15, 2024
justinvp
added
area/cli
UX of using the CLI (args, output, logs)
and removed
needs-triage
Needs attention from the triage team
labels
Apr 15, 2024
Frassle
added a commit
that referenced
this issue
Apr 22, 2024
6 tasks
github-merge-queue bot
pushed a commit
that referenced
this issue
May 2, 2024
<!--- Thanks so much for your contribution! If this is your first time contributing, please ensure that you have read the [CONTRIBUTING](https://github.com/pulumi/pulumi/blob/master/CONTRIBUTING.md) documentation. --> # Description <!--- Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. --> Fixes #15944. ## Checklist - [x] I have run `make tidy` to update any new dependencies - [x] I have run `make lint` to verify my code passes the lint check - [ ] I have formatted my code using `gofumpt` <!--- Please provide details if the checkbox below is to be left unchecked. --> - [ ] I have added tests that prove my fix is effective or that my feature works <!--- User-facing changes require a CHANGELOG entry. --> - [ ] I have run `make changelog` and committed the `changelog/pending/<file>` documenting my change <!-- If the change(s) in this PR is a modification of an existing call to the Pulumi Cloud, then the service should honor older versions of the CLI where this change would not exist. You must then bump the API version in /pkg/backend/httpstate/client/api.go, as well as add it to the service. --> - [ ] Yes, there are changes in this PR that warrants bumping the Pulumi Cloud API version <!-- @pulumi employees: If yes, you must submit corresponding changes in the service repo. --> --------- Co-authored-by: Thomas Gummerer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/cli
UX of using the CLI (args, output, logs)
kind/bug
Some behavior is incorrect or out of spec
resolution/fixed
This issue was fixed
What happened?
related to pulumi/pulumi-gcp#1900
Looks like for some resources the engine displays a diff even when the provider returns DIFF_NONE.
@Frassle suggested it is an issue in the display logic. From the original issue:
Fraser suggested this confirms it's the display logic going wrong here:
Example
Details in pulumi/pulumi-gcp#1900 (comment)
With GCP 7.18.0:
repro.sh
:import_template.json
:index.ts
:Notice that --expecto-no-change returns 0, running
pulumi up
returnsno changes
but preview still displays a diff:Output of
pulumi about
Additional context
No response
Contributing
Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).
The text was updated successfully, but these errors were encountered: