Why does CommandResult fail on-error instead of just on-exit? #9277
Unanswered
hcharley
asked this question in
Automation API
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Is there a need to exit early when pulumi has a single stderr?
If not, this might create false negatives, right?.
If the command succeeds, but has a stderr in it, doesn't this line of code present a bug where despite there being a success, it will exit as a fail?
Couldn't this also lead to only some of the stderr being recorded, possibly swallowing the error?
pulumi/sdk/nodejs/automation/cmd.ts
Line 86 in d695f04
The code here seems necessary and sufficient code listening to process.on('exit') here:
pulumi/sdk/nodejs/automation/cmd.ts
Line 86 in d695f04
Sorry if this doesn't make sense. Writing hastily on an Airplane that is about to land 😆 Its also why I didn't create an issue, and opted for a discussion.
Beta Was this translation helpful? Give feedback.
All reactions