Pulumi native provider generated code for secret value outputs bug

[frezbo]

When generating a secret value as output using a sample schema like https://github.com/frezbo/pulumi-provider-talos/blob/8300bfa1ea9a42e2bd9748a4ccf8d36d7af7ec54/provider/cmd/pulumi-resource-talos/schema.json#L124-L157 if output property secretsBundle is not duplicated in inputProperties and the output property is marked as a secret by adding like below snippet

"properties": {
                "secretsBundle": {
                    "type": "object",
                    "$ref": "#types/talos:bundle:SecretsBundle",
                    "secret": true
                }
            },

The generated code is like this:

+       if args.SecretsBundle != nil {
+               args.SecretsBundle = pulumi.ToSecret(args.SecretsBundle).(SecretsBundleTypeOutput)
+       }
+       secrets := pulumi.AdditionalSecretOutputs([]string{
+               "secretsBundle",
+       })
+       opts = append(opts, secrets)

as seen from the generated code, it considers SecretsBundle as an input argument as args.SecretsBundle

I've also looked into the pulumi code and I believe #7128 this change might have broken it. The test for the provider codegen

pulumi/pkg/codegen/testing/test/testdata/simple-yaml-schema/schema.yaml

Lines 77 to 85 in a1e18da

	properties:
	bar:
	type: string
	secret: true
	inputProperties:
	bar:
	type: string
	secret: true
	type: object

also defines an input property and an output property with the same name bar. Is that a requirement for the provider? I can't think of a use case where the input and output property always need to be the same name.

[nimbinatus]

Just in case it's not clear from the GitHub UI, we've opened an issue to correspond to this question. Thanks for bringing it up! I'll leave this open until there's more information in the attached issue: #8967

[frezbo]

Fixed as of #9052