Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

codegen: Handle 'secret(..)' functions #488

Open
abhinav opened this issue Aug 8, 2023 · 0 comments
Open

codegen: Handle 'secret(..)' functions #488

abhinav opened this issue Aug 8, 2023 · 0 comments
Labels
area/core kind/enhancement Improvements or new features

Comments

@abhinav
Copy link
Contributor

abhinav commented Aug 8, 2023

Hello!

  • Vote on this issue by adding a 馃憤 reaction
  • If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details

Follow-up to: #487 (comment)

Specifically, in gen_program.go, genResource has special handling for "secret"
separately from generator.function which doesn't recognize the "secret"
function.

This code was also previously tracking the arguments to the secret function
but not doing anything with that information.
This unused slice was dropped in #487.

This issue tracks the follow-up of that.

Affected area/feature

codegen

@abhinav abhinav added kind/enhancement Improvements or new features needs-triage Needs attention from the triage team labels Aug 8, 2023
@Frassle Frassle added area/core and removed needs-triage Needs attention from the triage team labels Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core kind/enhancement Improvements or new features
Projects
None yet
Development

No branches or pull requests

2 participants