Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Routne bridge upgrade makes the tests fail with Context cancelled #1479

Open
t0yv0 opened this issue Dec 4, 2023 · 0 comments
Open

Routne bridge upgrade makes the tests fail with Context cancelled #1479

t0yv0 opened this issue Dec 4, 2023 · 0 comments
Labels
kind/bug Some behavior is incorrect or out of spec

Comments

@t0yv0
Copy link
Member

t0yv0 commented Dec 4, 2023

What happened?

https://github.com/pulumi/pulumi-azure/actions/runs/7091708985/job/19303230174?pr=1478

Pre-testing bridge upgrade: #1478

Suspect change in play: pulumi/pulumi-terraform-bridge@48a4952 - with this bridge version, Context object propagates better as you would expect from the gRPC handler to the provider internals.

However if acceptance tests fail with "context cancelled" this is making the provider unusable, perhaps the lack of context propagation was making another latent issue? IS there something over-eagerly cancelling the context in this provider? this needs to be investigated.

Example

See above.

Output of pulumi about

N/A

Additional context

No response

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

@t0yv0 t0yv0 added kind/bug Some behavior is incorrect or out of spec needs-triage Needs attention from the triage team labels Dec 4, 2023
t0yv0 added a commit to pulumi/pulumi-terraform-bridge that referenced this issue Dec 4, 2023
Reverts #1537

This change (1537) has been observed to cause TestAccLoadbalancer fail in pulumi-gcp as well as cause multiple test failure in pulumi-azure (pulumi/pulumi-azure#1479). The failure is around Context being closed early. It is very likely that fixing context propagation in 1537 is making another latent issue with Context cancellation or timeouts manifest undesirably. For now this change is reverted until we can address this properly.
@t0yv0 t0yv0 removed the needs-triage Needs attention from the triage team label Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Some behavior is incorrect or out of spec
Projects
None yet
Development

No branches or pull requests

1 participant