-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Secrets concepts page engineering review #11320
Comments
Some things that should be updated as I was reading through the page:
Should be
configuration:
mySecretValue:
secret: true Should be: config:
mySecretValue:
type: string
secret: true
I don't know if we want to get into it at all, but it may be worth noting in a note that only config values marked as secrets are masking out. Marking a secret via
Should we have "Pulumi ESC" link to a main page on ESC that explains what it actually is? Maybe https://www.pulumi.com/docs/concepts/environments/ ? |
Cannot close issue:
Please fix these problems and try again. |
Regarding the Secrets concept page:
The text was updated successfully, but these errors were encountered: