-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bare URLs support behind a new flag #695
Comments
What I think other markdown parsers tend to do is only interpret
… while |
pulldown_cmark does not support detection of bare URLs. That is an extension that GitHub's parser has. On dingus, you can see that it parses the same as pulldown_cmark. The URLs need to be enclosed in angled brackets, like |
Therefore, supporting bare URLs should be a new feature behind a flag, a non-urgent enhancement. |
But what about the more general thing about underscores within words being interpreted as emphasis? That's independent of link detection, as I showed above. Is that just a fundamental difference between commonmark and GFM, i.e. not subject to configuration? |
Oh I see, so in the original example it's the |
Thanks for the details. |
Hey!
Let's assume this test:
This test is failing:
The first and second underscores in the links are considered as an emphasize. It seems like links have a lower priority than emphasizes.
Testing this here with Github markdown renderer: https://foo.bar/_/A and https://baz.qux/_/B; links are parsed correctly. I don't know what the spec says about priorities honestly, I believe it's implementation dependent.
The text was updated successfully, but these errors were encountered: