Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

matchId in prodCtx as a railway network linenumber #276

Open
bergmannjg opened this issue Nov 10, 2022 · 2 comments
Open

matchId in prodCtx as a railway network linenumber #276

bergmannjg opened this issue Nov 10, 2022 · 2 comments

Comments

@bergmannjg
Copy link
Contributor

In a db profile journey response the matchId in prodCtx seems to correspond to the railway network linenumber (Liniennummer) .

Can you please add the matchId to the FPTF operator object.

Here are 2 examples of the prodL parts of a journey response.

"prodL": [
    {
        "name": "IC 149",
        "number": "149",
        "icoX": 0,
        "cls": 2,
        "oprX": 0,
        "prodCtx": {
            "name": "IC   149",
            "num": "149",
            "matchId": "77",
            "catOut": "IC",
            "catOutS": "IC",
            "catOutL": "Intercity",
            "catIn": "IC",
            "catCode": "1",
            "admin": "80____"
        }
    }
]
"prodL": [
    {
        "name": "ICE 641",
        "number": "641",
        "icoX": 0,
        "cls": 1,
        "oprX": 0,
        "prodCtx": {
            "name": "ICE  641",
            "num": "641",
            "matchId": "10",
            "catOut": "ICE",
            "catOutS": "ICE",
            "catOutL": "Intercity-Express",
            "catIn": "ICE",
            "catCode": "0",
            "admin": "80____"
        }
    },
    {
        "name": "ICE 651",
        "number": "651",
        "icoX": 0,
        "cls": 1,
        "oprX": 0,
        "prodCtx": {
            "name": "ICE  651",
            "num": "651",
            "matchId": "10",
            "catOut": "ICE",
            "catOutS": "ICE",
            "catOutL": "Intercity-Express",
            "catIn": "ICE",
            "catCode": "0",
            "admin": "80____"
        }
    }
]
@derhuerst
Copy link
Member

derhuerst commented Nov 16, 2022

Thanks for bringing this up.

In a db profile journey response the matchId in prodCtx seems to correspond to the railway network linenumber (Liniennummer) .

Are there cases where matchId doesn't match the Liniennummer? Can you check local buses, trams, subway, ferries, etc. in some regions?

If matchId in fact turns out to (almost) always mean Liniennumber, I agree that we should let the DB profile expose it. In this case, having a more descriptive field name (e.g. liniennummer or lineName) would be more appropriate though IMO.

@bergmannjg
Copy link
Contributor Author

Some journey results with different products

profile db

  • journeys Hannover Berlin-Spandau: line.product: nationalExpress, line.name:'ICE 849', line.matchid: 10
  • journeys "Bad Bentheim" Hannover: line.product: national, line.name:'IC 147', line.matchid: 77
  • journeys Nollendorfpatz Wittenbergplatz: line.product: subway, line.name:'U 2', line.matchid: 2
  • journeys Brandenburg Berlin-Charlottenburg: line.product: regional, line.name:'RE 1', line.matchid: 1
  • journeys Rathaus-Spandau Alt-Kladow: line.product: bus, line.name:'Bus 135', line.matchid: 135
  • journeys Kirchzarten Freiburg: line.product: suburban, line.name:'S 10', line.matchid: 10
  • journeys "München Donnersbergerbrücke" "München HBF": line.product: suburban, line.name:'S 8', line.matchid: 8
  • journeys Salzburg "Wien HBF": line.product: nationalExpress, line.name:'RJX 67', line.matchid: 67

profile bvg

  • journeys "Osloer Str" Wedding: line.product: subway,, line.name:'U6', line.matchid: U6

The line.name or line.fahrtnr conceptually only differs from line.matchid (or linenumber) for products nationalExpress or national.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants