Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graceful Shutdown Configuration #4929

Open
1 task done
mackreese opened this issue Nov 25, 2023 · 1 comment
Open
1 task done

Graceful Shutdown Configuration #4929

mackreese opened this issue Nov 25, 2023 · 1 comment
Labels
feature request A request for a new feature.

Comments

@mackreese
Copy link

Is there an existing feature request for this?

  • I have searched the existing issues before opening this feature request.

Describe the feature you would like to see.

I would like to see a feature similar to the "Startup Configuration" feature, where you can configure a console output to be recognized as the server shutting down gracefully.

This would be useful for applications that have the ability to be shutdown from within the application. Currently, if you shutdown from within the application, Pterodatcyl treats it like a crash and reboots the server automatically. With this feature, rather than treating the shutdown as a crash and rebooting, it would behave like a graceful shutdown.

Describe the solution you'd like.

My ideal implementation for this would be the same as the Startup Configuration's "done" value. Say for instance the server outputs "Shutdown initiated" to the console when a shutdown is triggered from within the application. If the Egg was configured to look for "Shutdown initiated", it would not treat the shutdown as a crash, and would behave like a graceful shutdown.

Additional context to this request.

No response

@mackreese mackreese added the feature request A request for a new feature. label Nov 25, 2023
@Software-Noob
Copy link
Member

There's detect_clean_exit_as_crash key in the Wings config.yaml file. By default, it's enabled and treats all exit codes as crashes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request A request for a new feature.
Projects
None yet
Development

No branches or pull requests

2 participants