[New PR on phpMyAdmin] #232
Conversation
| @@ -0,0 +1,153 @@ | |||
| #!/bin/bash | |||
|
|
|||
There was a problem hiding this comment.
Please do not add || exit to all of the commands you run, just add the following code to the top of the file and it will exit automatically if one of the commands fail.
| set -e | |
| echo "* The default directory exists, proceeding with the installation...*" | ||
| echo "********************************************************************" | ||
| cd /var/www/pterodactyl/public || exit | ||
| mkdir -p phpmyadmin && chown www-data.www-data /var/www/pterodactyl/public/phpmyadmin -R |
There was a problem hiding this comment.
Are you sure www-data works for every operating system like CentOS and Debian based?
phpmyadmin-install.sh
Outdated
|
|
||
| echo | ||
| echo -n "* Password (phpmyadminuser2021): " | ||
| read -r MYSQL_PASS_INPUT |
There was a problem hiding this comment.
Please use password inputs for reading passwords because doing it like this would show the password in the terminal.
phpmyadmin-install.sh
Outdated
| echo "******************************" | ||
| echo "* Username: $MYSQL_USER" | ||
| echo "* Database name: $MYSQL_DATABASE" | ||
| echo "* Password: $MYSQL_PASS" |
There was a problem hiding this comment.
Don't show the password in the summary.
| echo "* Password: $MYSQL_PASS" | |
| echo "* Password: [censored]" |
| echo "* Creating database..." | ||
| mysql -u root -e "CREATE DATABASE ${MYSQL_DATABASE};" | ||
|
|
||
| echo "* Grant privileges..." |
There was a problem hiding this comment.
A small typo here:
| echo "* Grant privileges..." | |
| echo "* Granting privileges..." |
| echo | ||
| echo "Here it is:" | ||
| echo "*********************************************" | ||
| openssl rand -base64 32 |
There was a problem hiding this comment.
Please use sed to automatically write to the configuration file instead of letting the user configure it by themselves.
| summary | ||
|
|
||
| continue_install() { | ||
| echo "**************************************************" |
There was a problem hiding this comment.
Please use correct indent levels for the code in functions.
|
This script was produced and tested using only Ubuntu 20.04 as a base, I don't use other distros, so I didn't bother to do it. |
Please do bother to do it, since this script is for CentOS 7/8 and Ubuntu 18.04/20.04 and Debian 9/10 |
|
Hello, may I ask why this was closed? |
Because apparently my help is not relevant when reading this.
|
|
Sorry, I don't think that was the intended message. Your contribution is always appreciated! I can make sure to test it on other distros, but there are other changes suggested. Let us know if you are not able to solve them and I can modify your PR directly. I don't think you have to close it 🙂. |
With that I meant that you should make the script compatible for the other distros, not that you're not needed. |
I will need help using SED to automatically paste the information into the configuration file.
|
Anything new regarding this? I could solve some of the CI linting errors but you have set to not allow edits from the maintainer. Do you wish to continue working on this or should I merge into another branch and see if I can continue on it? 🙂 |
|
When this will be added? |
|
There are unsolved problems that need to be changed before we can merge, but this PR does not allow edits from the maintainer (me) so it's up to the submitter 🙂 |
|
any updates on this feature? |
New PR Here |
New PR only with phpMyAdmin modifications, without all those other changes.
Fixes #194