New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data race on pterm.SpinnerPrinter #482
Labels
bug
Something isn't working
Comments
Hi @KirillSerebryakov123, thanks for reporting! This should get fixed with #447 :) |
8 tasks
hey all, any update here? I'm seeing the same issue running go 1.21 with the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hello.
I have identified a data race on the
pterm.SpinnerPrinter
.General information:
Steps to reproduce:
run following code with
go run -race
After inspecting the source code i have found out that the reason is the go routine, spawned in
func (s SpinnerPrinter) Start(text ...interface{}) (*SpinnerPrinter, error)
pterm/spinner_printer.go
Line 127 in 971fa81
IsActive
field.pterm/spinner_printer.go
Line 141 in 971fa81
func (s *SpinnerPrinter) Stop() error
writes to this field from anothe routine, and this causes a data race.pterm/spinner_printer.go
Line 171 in 971fa81
The text was updated successfully, but these errors were encountered: