-
-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong CA Certificates used in requests.Session.send #6647
Comments
sunnstix
changed the title
Wrong CA Certificates file used in requests.Session.send
Wrong CA Certificates used in requests.Session.send
Feb 23, 2024
I can confirm I'm seeing this behavior when using prepared requests and |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug in requests.sessions.py:
requests/src/requests/sessions.py
Lines 579 to 589 in b8be93a
session.merge_environment_settings is called in session.request and not in session.send which means if users want to build their own prepared requests (see example below), the correct certificates file will not be used unless explicitly passed to send.
I believe these environment settings should be updated in session.send instead.
Reproduction Steps
Expected Result
No output
Actual Result
System Information
The text was updated successfully, but these errors were encountered: