-
-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android build breaks due to the release of androidx.browser:browser:1.6.0-beta01 on June 22th #423
Comments
Can you guys fix this asap? Don't want to change android/build.gradle file...:( |
FYI, for those of you using Expo, I think I have found (a quite hacky) workaround to be able to at least build your android binaries locally again (without ejecting your whole project). You can (of course) edit the gradle file as given in PR #424 to use version 1.5.0, locally, but since metro is running yarn install by itself when building with eas build --local, it will not be enough to make if you only do so in your local node_modules. You also have to change the file in yarn's cache directory, too. After that (and maybe clearing your gradle caches, too), you should be able to build again (until you clear yarn's cache, of course). At least, that worked for me. |
please don't use @hbel solution 😬 rely on a custom dev client (see: https://docs.expo.dev/develop/development-builds/introduction/) and use a custom plugin to change |
I'm terribly sorry for causing that confusion. I actually tried to set the ext vars first, but seemed to have not cleared all the caches, so it did not work. I can confirm that this solution works - tried it in several projects. |
I got it to work very simply it took me a few hours of trying different solutions but ultimately my solution was solved by adding the plugins to the app.json for my expo project also making sure to format it correctly and install vars this solution was recommended already previously so this is nothing new "plugins": [ |
My app still crashes though I added androidXBrowser = "1.5.0" in android/build.gradle file. |
In
|
This turned out to be the correct answer for our case. |
The current build seems to set the version as: androidx.browser:browser:1.8.0-alpha01. expo-gradle-ext-vars solution does not seem to work as intended anymore. |
Which platform(s) does your issue occur on?
Please, provide the following version numbers that your issue occurs with:
androidx.browser:browser:1.6.0-beta01
has been released few days ago, see https://android.googlesource.com/platform/frameworks/support/+/635f86783709c977282f9867d5bcd7662c884df0compileSdkVersion
34compileSdkVersion
33androidx.browser:browser:1.+
resolves toandroidx.browser:browser:1.6.0-beta01
due to this code: https://github.com/proyecto26/react-native-inappbrowser/blob/develop/android/build.gradle#L55-L64Please, tell us how to recreate the issue in as much detail as possible.
Build on android
How to fix?
Add a
androidXBrowser = "1.5.0"
in your projectandroid/build.gradle
:It already happened before
See this issue: #386
See this issue: #298
A more robust solution (e.g. fixed version instead of
1.+
) would be greatIt happens all the time...
The text was updated successfully, but these errors were encountered: