Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use catbuffer to generate the SDK API #13

Open
tonowie opened this issue May 6, 2019 · 2 comments
Open

use catbuffer to generate the SDK API #13

tonowie opened this issue May 6, 2019 · 2 comments
Labels
enhancement New feature or request

Comments

@tonowie
Copy link
Contributor

tonowie commented May 6, 2019

nemtech's catbuffer is to be used to generate objects for serialization. move to it and adjust the code/tests to use new definitions.

@tonowie tonowie added enhancement New feature or request pre-release labels May 6, 2019
@tonowie tonowie modified the milestone: SDK goes public May 6, 2019
@tonowie
Copy link
Contributor Author

tonowie commented May 6, 2019

initial tests show that catbuffer code is very different from what we have and I am removing this from the initial release. it should go to the 1.0.0 release though after it is stabilized

I have forked catbuffer to https://github.com/bad-weather-corp/catbuffer and will attend it as time permits

@tonowie
Copy link
Contributor Author

tonowie commented Jul 21, 2019

ok nemtech has moved to the catbuffer serialization. I misunderstood the intention behind it because what nemtech did was using it solely for serialization => no "regenerate on change and you are done" but "regenerate on change and then refactor all your code referencing what was generated". That lowers the bar for the use of the catbuffers a lot because API for SDK remains the same

I think I will get back to this once dragon release is out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant