Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(table-overview): Multiple changes on dashboard table from overview #3773

Merged
merged 10 commits into from Apr 16, 2024

Conversation

pedrooot
Copy link
Member

Context

Fixes #3752

Description

This pr includes multiple table-dashboard fixes/improvements:

  • Change color for each status in table
  • Add export in xlsx button
  • Add paginator in table
  • Add filter in each table-column
  • Sort in table header

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@pedrooot pedrooot requested review from a team as code owners April 15, 2024 14:34
Copy link

codecov bot commented Apr 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.62%. Comparing base (f8476de) to head (8e0c3b2).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3773      +/-   ##
==========================================
+ Coverage   85.60%   85.62%   +0.01%     
==========================================
  Files         722      722              
  Lines       22527    22527              
==========================================
+ Hits        19284    19288       +4     
+ Misses       3243     3239       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sergargar
Copy link
Member

Great job! Could it be possible to make the text of the columns centered? Also the check ID column also contains the resource ID.

@pedrooot
Copy link
Member Author

pedrooot commented Apr 15, 2024

Hey! @sergargar I reviewed your comment and found a bug in download buttons!

Copy link
Member

@sergargar sergargar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job!

@sergargar sergargar merged commit 81778f7 into master Apr 16, 2024
11 checks passed
@sergargar sergargar deleted the overview-table branch April 16, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prowler v4.0 dashboard suggestions
2 participants