Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: False positve on ec2_securitygroup_not_used with Batch Compute #3264

Open
christiandavilakoobin opened this issue Jan 11, 2024 · 6 comments
Assignees
Labels
feature-request New feature request for Prowler. provider/aws Issues/PRs related with the AWS provider severity/low Bug won't result in any noticeable breakdown of the execution.

Comments

@christiandavilakoobin
Copy link
Contributor

Steps to Reproduce

If a security group is assigned only on a lambda function, prowlers thinks that is unused and rises an alert.

Expected behavior

Prowler should detect that is assigned to a lambda

Actual Result with Screenshots or Logs

image image

How did you install Prowler?

Docker (docker pull toniblyx/prowler)

Environment Resource

Docker cointainer

OS used

Linux

Prowler version

3.12

Pip version

The one inside docker image

Context

No response

@sergargar sergargar self-assigned this Jan 12, 2024
@sergargar
Copy link
Member

Hi @christiandavilakoobin , thanks for reaching us out!
However, I cannot reproduce your error and the check works as expected on my side. Make sure that you have the latest version and that you are not getting any error when Prowler retrieves the information from the Lambda functions, using the flag --log-level ERROR.

@sergargar sergargar added status/awaiting-reponse Waiting response from Issue owner severity/low Bug won't result in any noticeable breakdown of the execution. provider/aws Issues/PRs related with the AWS provider and removed status/needs-triage Issue pending triage labels Jan 12, 2024
@christiandavilakoobin
Copy link
Contributor Author

Hi @sergargar!

My bad! I just checked again, and I had an exception on this rule, so all of them appear as warning, not only the not used ones. I just saw that on the same screenshot I send this, it says "is used". When I removed the exception it works fine.

@sergargar
Copy link
Member

Awesome, glad that it works. I will close this issue then.
Let us know if you have any other issues.

@christiandavilakoobin
Copy link
Contributor Author

Hi again,

Regardless, it same to fail on Batch Compute. I have a security group assigned to a batch compute, but Prowler says it is not attached:

image image

@sergargar sergargar reopened this Jan 16, 2024
@sergargar sergargar changed the title [Bug]: False positve on ec2_securitygroup_not_used with lambdas [Bug]: False positve on ec2_securitygroup_not_used with Batch Compute Jan 16, 2024
@sergargar
Copy link
Member

Hi @christiandavilakoobin, since we still do not cover the batch service, we cannot check that use case. I have include it in our roadmap. Thanks for letting us know!

@sergargar sergargar added feature-request New feature request for Prowler. and removed bug status/awaiting-reponse Waiting response from Issue owner labels Jan 16, 2024
@christiandavilakoobin
Copy link
Contributor Author

Roger that! I'll add those security groups to an exception, meanwhile.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request New feature request for Prowler. provider/aws Issues/PRs related with the AWS provider severity/low Bug won't result in any noticeable breakdown of the execution.
Projects
None yet
Development

No branches or pull requests

2 participants