-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use spaces instead of tabs for generated code. #4
Comments
The documentation of php-code-generator is saying
Well in the doc of php-code-formatter
Last commit is 7 month ago - so - maybe we should replace simply "\t" with $n * " " where the replace and $n is configurable? But then the problem with ugly formatted code generated by php-code-generator will stay (as far as it exists). Well, maybe a replacement of php-code-generator is another solution. For Example zend-code |
I think the body is not an issue right now, since we have complete control over what is inside the body. Currently we use already spaces in there, however it gets indented with tabs (since you don't use indentation in the argument of I'm not sure where that tab is hardcoded, but maybe we can just subclass the generator/visitor that generates the actual code, replace it or make it configureable. Just replacing all \t could also be a way, although not so sexy. |
Currently the used library uses tabs, I guess hardcoded. We should make it configurable.
https://github.com/gossi/php-code-generator
See
Propel3/src/Propel/Generator/Builder/Om/AbstractBuilder.php
Line 113 in e8e0db9
The text was updated successfully, but these errors were encountered: