-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LinodeSD configuration fields to the Scrape Config CRD #6586
Add LinodeSD configuration fields to the Scrape Config CRD #6586
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, just had a very brief look over the PR... I didn't have the time for a detailed review
There's a problem with the generated code it seems like, what should we do? |
7017c8d
to
a870f06
Compare
PS: I will squash the commits once the PR gets approval! |
Hmmmm, not sure what's happening here... The |
3fa4147
to
77eddf3
Compare
Can you pull latest changes from main and run generate again. There was API dependencies bump done today looks like failures in generate is due to that. |
f0d005b
to
34cd7c4
Compare
831e05b
to
b95705a
Compare
I also added a validation for MinLength for the region field, considering that Prometheus rejects empty string values anyway. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 just a few nits!
Please rebase on top of main, I think that #6641 clashes with your change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rebase on top of main, I think that #6641 clashes with your change.
36837fd
to
5984698
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just 1 small change suggestion.
5984698
to
02dde06
Compare
02dde06
to
7984d14
Compare
Rebased on top of main! |
Description
This PR adds the LinodeSD configuration fields to the ScrapeConfig CRD.
Closes #6579
Type of change
What type of changes does your code introduce to the Prometheus operator? Put an
x
in the box that apply.CHANGE
(fix or feature that would cause existing functionality to not work as expected)FEATURE
(non-breaking change which adds functionality)BUGFIX
(non-breaking change which fixes an issue)ENHANCEMENT
(non-breaking change which improves existing functionality)NONE
(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)Verification
Please check the Prometheus-Operator testing guidelines for recommendations about automated tests.
Changelog entry
Please put a one-line changelog entry below. This will be copied to the changelog file during the release process.