-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve e2e testing for ScrapeConfig #6452
Labels
Milestone
Comments
Looking into this, will try to come up with some ideas after I get a better idea of this. Could you suggest some place to start? |
This issue has been automatically marked as stale because it has not had any activity in the last 60 days. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Component(s)
ScrapeConfig
What is missing? Please describe.
For ScrapeConfig we have added support for multiple SDs for which we haven't added e2e tests. The idea is to improve the test coverage by testing SDs in e2e. Logging this issue to explore possible options
One of the option is to utilize testcontainers.
For example we could use it for testing ConsulSD. We would need to register some service or could be consul itself which comes registered by default and add test to discover the services registered in consul through ScrapeConfig.
Describe alternatives you've considered.
NA
Environment Information.
Environment
Kubernetes Version:
Prometheus-Operator Version:
NA
The text was updated successfully, but these errors were encountered: