-
-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prometheus.ITimer vs System.Threading.ITimer in .NET8 #455
Comments
Yes, perhaps indeed. However, it seems too late to change anything here. This is exactly the naming conflict that namespaces exist to work around. Or do you propose some specific change to the library with this issue? It is not clear what is the purpose of this post - please clarify. |
It was mostly to point out the issue as most of the people using the library will face the issue upgrading to .NET8+ considering how common The fix is easy enough and just require to convert most variable declaration from So, if you think changing the interface name is much worse than that (and I think you are probably right) you can archive the issue. |
.NET8 introduce an new
System.Threading.ITimer
interface that have the same name asPrometheus.ITimer
You need to change all
ITimer
toPrometheus.ITimer
to fix the .NET8 upgrade.Maybe
ITimer
is a little too generic of a name no?The text was updated successfully, but these errors were encountered: