Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Upgrade github.com/go-kit/kit to 0.12.0 #313

Open
zhan9san opened this issue Apr 4, 2023 · 0 comments
Open

[FEATURE] Upgrade github.com/go-kit/kit to 0.12.0 #313

zhan9san opened this issue Apr 4, 2023 · 0 comments
Labels
feature good first issue Good for newcomers

Comments

@zhan9san
Copy link
Collaborator

zhan9san commented Apr 4, 2023

Is your feature request related to a problem? Please describe.

Related to #298

If github.com/go-kit/kit is upgraded to 0.12.0, there are some incompatible change. So we need make some changes in code base as well.

  Running [/home/runner/golangci-lint-1.52.2-linux-amd64/golangci-lint run --out-format=github-actions --timeout=2m30s] in [] ...
  Error: Error return value of `(github.com/go-kit/log.Logger).Log` is not checked (errcheck)
  Error: Error return value of `(github.com/go-kit/log.Logger).Log` is not checked (errcheck)
  Error: Error return value of `logger.Log` is not checked (errcheck)
  Error: Error return value of `logger.Log` is not checked (errcheck)
  Error: Error return value of `logger.Log` is not checked (errcheck)
  Error: SA1019: "github.com/go-kit/kit/log" is deprecated: Use github.com/go-kit/log instead. (staticcheck)
  Error: SA1019: "github.com/go-kit/kit/log/level" is deprecated: Use github.com/go-kit/log/level instead. (staticcheck)
  Error: SA1019: "github.com/go-kit/kit/log" is deprecated: Use github.com/go-kit/log instead. (staticcheck)
  Error: Error return value of `l.logger.Log` is not checked (errcheck)
  Error: Error return value of `l.logger.Log` is not checked (errcheck)
  Error: Error return value of `l.logger.Log` is not checked (errcheck)
  Error: SA1019: "github.com/go-kit/kit/log" is deprecated: Use github.com/go-kit/log instead. (staticcheck)
  Error: Error return value of `(github.com/go-kit/log.Logger).Log` is not checked (errcheck)
  Error: SA1019: "github.com/go-kit/kit/log/level" is deprecated: Use github.com/go-kit/log/level instead. (staticcheck)
  Error: SA1019: "github.com/go-kit/kit/log/level" is deprecated: Use github.com/go-kit/log/level instead. (staticcheck)

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@zhan9san zhan9san added feature good first issue Good for newcomers labels Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant